[PATCH] D33664: [Lexicon] Add GVN

Davide Italiano via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 10 20:53:22 PDT 2017


davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

If you don't mind, I like the description at the top of NewGVN better, i.e.

  /// GVN partitions values computed by a function into congruence classes.
  /// Values ending up in the same congruence class are guaranteed to be the same
  /// for every execution of the program. In that respect, congruency is a
  /// compile-time approximation of equivalence of values at runtime.

Can you use this one? I also would remove the bit about transformations (many thinks as GVN as PRE but it's actually not).
With that, LGTM, you don't need to resubmit for another look.


https://reviews.llvm.org/D33664





More information about the llvm-commits mailing list