[llvm] r305105 - [ADT] Make iterable SmallVector template overrides more specific

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 10 16:40:37 PDT 2017


I'd probably test to see if putting __attribute__((used)) on them is enough
to suppress the warning. Otherwise probably move the class outside the
function so it's no longer local.

On Sat, Jun 10, 2017 at 4:33 PM Francis Ricci <francisjricci at gmail.com>
wrote:

> Looping in David on this (regards warnings introduced by our reverse
> iterator test)
>
> On Sat, Jun 10, 2017, 7:21 PM Davide Italiano <davide at freebsd.org> wrote:
>
>> FWIW, a not-so-recent Fedora (1.5 years ago) says:
>>
>> [davide at cupiditate ~]$ rpm -q libstdc++
>> libstdc++-6.3.1-1.fc24.x86_64
>> libstdc++-6.3.1-1.fc24.i686
>>
>> From what I understand we still support GCC 4.8 but maybe with GCC 7
>> out we might consider bumping our minimum supported version?
>>
>> --
>> Davide
>>
>> On Sat, Jun 10, 2017 at 4:13 PM, Davide Italiano <davide at freebsd.org>
>> wrote:
>> > Ugh, sorry, spoke too soon.
>> > Apparently some relatively ancient version of libstdc++ needs these.
>> >
>> >
>> http://lab.llvm.org:8011/builders/clang-x86_64-linux-selfhost-modules-2/builds/8386/steps/compile/logs/stdio
>> >
>> > --
>> > Davide
>> >
>> > On Sat, Jun 10, 2017 at 4:05 PM, Francis Ricci <francisjricci at gmail.com>
>> wrote:
>> >> Thanks Davide.
>> >>
>> >> On Sat, Jun 10, 2017, 7:02 PM Davide Italiano <davide at freebsd.org>
>> wrote:
>> >>>
>> >>> On Sat, Jun 10, 2017 at 3:54 PM, Galina Kistanova via llvm-commits
>> >>> <llvm-commits at lists.llvm.org> wrote:
>> >>> > Hello Francis,
>> >>> >
>> >>> > Could you fix the warnings added by this commit, please?
>> >>> >
>> >>>
>> >>> r305157. FWIW, it's generally easier to just fix when the time needed
>> >>> to write the mail is equivalent to the time of writing the patch,
>> Galina
>> >>> :)
>> >>>
>> >>> --
>> >>> Davide
>> >
>> >
>> >
>> > --
>> > Davide
>> >
>> > "There are no solved problems; there are only problems that are more
>> > or less solved" -- Henri Poincare
>>
>>
>>
>> --
>> Davide
>>
>> "There are no solved problems; there are only problems that are more
>> or less solved" -- Henri Poincare
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170610/86eb3ebb/attachment.html>


More information about the llvm-commits mailing list