[PATCH] D34075: [compiler-rt][builtins] Better Fuchsia support

[Saleem Abdulrasool via Phabricator via llvm-commits]

compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/builtins/CMakeLists.txt:226
+    clear_cache.c
+    eprintf.c)
+endif()
----------------
`eprintf` is a darwin specific thing, not to be added everywhere.  Is this still being filtered out?


================
Comment at: lib/builtins/int_util.c:50
+
+__attribute__((weak)) __attribute__((visibility("hidden")))
+void compilerrt_abort_impl(const char *file, int line, const char *function) {
----------------
Please use the reserved spellings of the attributes.


Repository:
  rL LLVM

https://reviews.llvm.org/D34075