[PATCH] D34072: Fix alignment bug in COFF emission.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:511
+
+  Current += SectionOnePadding;
 }
----------------
ruiu wrote:
> Do you have to memorize how large was a padding? I mean you may be able to do this.
> 
>   Current = alignTo(Current, 8)
Hmm doesn't that depend on the way the loader aligns cvtres in memory?  For example, it could be possible for the system to align the FileOutputBuffer on 4 bytes instead of 8 bytes.  So aligning to 8 bytes would actually be aligning to 4 bytes.


https://reviews.llvm.org/D34072