[PATCH] D33894: Align definition of DW_OP_plus with DWARF spec [3/3]

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Ah ok, I see. The cleanest way to do this would be to

1. Implement support for DW_OP_plus_constu in LLVM
2. Switch over Clang to use DW_OP_plus_constu

3a. Retire the old DW_OP_plus and implement the bitcode upgrade in LLVM
3b. Retire the old DW_OP_minus (AFAIK not used by clang) and implement the bitcode upgrade in LLVM
(The last two can be one joined commit so we only need to bump the DIExpression version number once and keep the upgrade code simple).

I understand that this may sound like a lot of busywork at first, but the code is already there and with some git rebase -i and git commit -p reordering the patches this way should go relatively fast. It would have the big advantage that each commit can be committed individually and safely be reverted. (The current patches increment the version number in 1/3 and implement the bitcode upgrade for DW_OP_minus later in 3/3).

Would this work for you?


https://reviews.llvm.org/D33894