[PATCH] D33688: [Polly] Heap allocation for new arrays

[Andreas Simbuerger via Phabricator via llvm-commits]

simbuerg added inline comments.


================
Comment at: include/polly/ScopInfo.h:2590
+      Value *BasePtr, Type *ElementType, ArrayRef<const SCEV *> Sizes,
+      MemoryKind Kind, const char *BaseName = nullptr, bool IsOnHeap = false);
 
----------------
Meinersbur wrote:
> Please document the new parameter.
> 
> Instead of passing to every constructor, you could also defeault-initialize it to false and add a `setIsOnHeap` accessor (or similar name) to change that property after creation.
I would also recommend going for default initialization to false and provide a setter for the property.


https://reviews.llvm.org/D33688