[PATCH] D33847: [PartialInlining] Enhance code outliner to sink locals declared outside the outline region

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 23:09:58 PDT 2017


davidxl added a comment.

Any more comments?



================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:185-186
+          StoreInst *SI = cast<StoreInst>(&II);
+          if (!SI->isUnordered())
+            return false;
+          MemAddr = SI->getPointerOperand();
----------------
davide wrote:
> Can you add a comment explaining why you skip ordered load/stores?
not necessarily needed. Removed.


https://reviews.llvm.org/D33847





More information about the llvm-commits mailing list