[PATCH] D34020: Implement COFF emission for parsed Windows Resource ( .res) files.

[David Majnemer via Phabricator via llvm-commits]

majnemer added inline comments.


================
Comment at: llvm/lib/Object/WindowsResource.cpp:391
+  return Now;
+}
+
----------------
ruiu wrote:
> zturner wrote:
> > majnemer wrote:
> > > ruiu wrote:
> > > > Incremental linking sees file itself's timestamp instead of a timestamp field inside a file, no?
> > > > 
> > > > Reproducible build is generally important in many use cases, and you don't want to break that property unless breaking it is absolutely necessary. It is so convenient if you can always create an identical output from the same source tree.
> > > The MS linker actually uses the time in the file. I learned this the hard way getting LLVM obj files compatible with LINK.exe
> > Shouldn't we do whatever MS does?
> If that's needed, then well, we have to do that.
I bet they support the /Brepro flag that CL.exe has. If they support it we could have it too and fill it with whatever value they do. IIRC, they use 0xFFFFFFFF in CL to make it so that it always looks "new".


https://reviews.llvm.org/D34020