[llvm] r303490 - COFF: migrate def parser from LLD to LLVM [1/2]

[Martell Malone via llvm-commits]

>From Galinas' commit

> // TODO: Name.Offset.Offset here and in the all similar places below
> // suggests a names refactoring. Maybe StringTableOffset.Value?

 See rL305029

On Fri, Jun 9, 2017 at 1:10 AM, Rui Ueyama <ruiu at google.com> wrote:

> Which names are you talking about?
>
> On Thu, Jun 8, 2017 at 5:02 PM, Martell Malone <martellmalone at gmail.com>
> wrote:
>
>> LGTM
>> Removing the cast with a note about naming makes a lot of sense here.
>>
>> Thanks Galina for finding a reasonable solution to fix the warnings.
>> Rui, I can follow up with a commit on the naming if you have a suggestion?
>>
>> Best,
>> Martell
>>
>> On Fri, Jun 9, 2017 at 12:38 AM, Galina Kistanova <gkistanova at gmail.com>
>> wrote:
>>
>>> I have committed the fix as r305029.
>>>
>>> Naming there looks a bit odd, but this is for somebody else to address.
>>> :)
>>>
>>> Thanks
>>>
>>> Galina
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170609/062e6fcd/attachment.html>