[PATCH] D33921: Write summaries for merged modules when splitting modules for ThinLTO.
Teresa Johnson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 8 15:36:52 PDT 2017
tejohnson added inline comments.
================
Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:59
+
+ FULL_LTO_GLOBALVAL_SUMMARY_BLOCK_ID,
};
----------------
Why use a different block ID? Since we are marking the module with a module flag, it doesn't seem necessary, and appears to be handled the same. I see your follow-on patch does something different based on the block id, but could/should that check the module flag instead?
https://reviews.llvm.org/D33921
More information about the llvm-commits
mailing list