[PATCH] D33996: Improve consistency and flexibility with llvm-pdbdump subcommands

[Zachary Turner via Phabricator via llvm-commits]

zturner marked an inline comment as done.
zturner added inline comments.


================
Comment at: llvm/tools/llvm-pdbdump/YAMLOutputStyle.cpp:47
     opts::pdb2yaml::DbiStream = true;
-    opts::pdb2yaml::DbiModuleInfo = true;
-    opts::pdb2yaml::DbiModuleSyms = true;
-    opts::pdb2yaml::DbiModuleSourceFileInfo = true;
-    opts::pdb2yaml::DbiModuleSourceLineInfo = true;
+    // opts::pdb2yaml::DbiModuleSourceLineInfo = true;
     opts::pdb2yaml::TpiStream = true;
----------------
inglorion wrote:
> Looks like there's still a line of commented-out code.
Removed offline.


================
Comment at: llvm/tools/llvm-pdbdump/llvm-pdbdump.cpp:901
+
+  if (opts::shared::DumpModuleSyms || opts::shared::DumpModuleFiles)
+    opts::shared::DumpModules = true;
----------------
inglorion wrote:
> That takes care of some of the scattering of the code, but most of the code for pdb2yaml::All is still in YAMLOutput.cpp. Did you intend to move that here, too?
No because none of that is related to the shared options.  You only mentioned handling the shared options in a common place.


https://reviews.llvm.org/D33996