[llvm] r304954 - [CodeGen] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes (NFC).

[Eugene Zelenko via llvm-commits]

Hi, Krzysztof!

On Thu, Jun 8, 2017 at 7:29 AM, Krzysztof Parzyszek
<kparzysz at codeaurora.org> wrote:
> On 6/7/2017 6:53 PM, Eugene Zelenko via llvm-commits wrote:
>>
>>
>> -typedef uint64_t                DFAInput;
>> -typedef int64_t                 DFAStateInput;
>> +using DFAInput = uint64_t;
>> +using DFAStateInput = int64_t;
>
>
> Are you going to be changing all typedefs to usings?

Yes, I'll try to make this change. In fact, usings were used instead
of typedefs in various places, but not consistently.

>> Modified: llvm/trunk/include/llvm/CodeGen/GCMetadataPrinter.h
>> [...]
>>   -private:
>> +public:
>>     GCMetadataPrinter(const GCMetadataPrinter &) = delete;
>>     GCMetadataPrinter &operator=(const GCMetadataPrinter &) = delete;
>
> This isn't really NFC.

This is trivial change suggested by modernize-use-equals-delete. There
is no need to make deleted members private. Actually I fixed these
warnings in big part of LLVM code base already.

> -Krzysztof
>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by
> The Linux Foundation

Eugene.