[PATCH] D34028: [Bitcode] Add thumb-mode to target-features in metadata loader.

[Javed Absar via Phabricator via llvm-commits]

javed.absar added inline comments.


================
Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:594
+    const Triple TT(TheModule.getTargetTriple());
+    if (TT.getArch() != Triple::thumb && TT.getArch() != Triple::thumbeb &&
+        TT.getArch() != Triple::arm && TT.getArch() != Triple::armeb)
----------------
maybe you should add isARMorThumb to ADT/Triple.h and use it, much like isPS4(), isAndroid etc?


================
Comment at: test/Bitcode/thumb-mode-upgrade-arm.ll:1
+; RUN: llvm-dis -o - %s.bc | FileCheck %s
+
----------------
Could the same check be achieved  using something like 'llvm-as < %s | llvm-dis ..."?


https://reviews.llvm.org/D34028