[PATCH] D31583: StackColoring: smarter check for slot overlap

Ariel Ben-Yehuda via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 8 04:11:22 PDT 2017


arielb1 updated this revision to Diff 101884.
arielb1 added a comment.

Changed else/if nesting in that part.

I'm not too worried about any O(n^2) part - both the old and the new code do an O(# slots) * O(# slots) overlap check, and I don't remember it being a particularly expensive pass.


https://reviews.llvm.org/D31583

Files:
  lib/CodeGen/StackColoring.cpp
  test/CodeGen/X86/StackColoring.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D31583.101884.patch
Type: text/x-patch
Size: 15833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170608/57bd38d5/attachment.bin>


More information about the llvm-commits mailing list