[PATCH] D32991: [ELF] Initial migration of AVR target

[Leslie Zhai via Phabricator via llvm-commits]

xiangzhai updated this revision to Diff 101864.
xiangzhai added a comment.

Dear Rui,

> you need to handle the same relocations in getRelExpr(), getImplicitAddend(), relocateOne()

I followed elf32-avr R_AVR_32 <https://sourceware.org/git/?p=binutils.git;a=blob;f=bfd/elf32-avr.c;h=43100cd20fc0f48e26bdbd8c841c661f9c37c33f;hb=HEAD#l132> and R_AVR_CALL <https://sourceware.org/git/?p=binutils.git;a=blob;f=bfd/elf32-avr.c;h=43100cd20fc0f48e26bdbd8c841c661f9c37c33f;hb=HEAD#l388> to handle the relocations in getRelExpr, getImplicitAddend and relocateOne.

> a test file

Dear Rafael,

but I met llvm-mc not enabled instruction issue:

  llvm-mc -filetype=obj -triple=avr-unknown-linux ../tools/lld/test/ELF/basic-avr.s -o /tmp/basic-avr.o
  ../tools/lld/test/ELF/basic-avr.s:7:3: error: instruction requires a CPU feature not currently enabled
    call foo
    ^
  ../tools/lld/test/ELF/basic-avr.s:10:3: error: instruction requires a CPU feature not currently enabled
    jmp foo
    ^

Please point out my fault, thanks a lot!

> but after you make a selection, you need to stick with it

Rui, you are my example, you are learning in the University and meanwhile working in the company, it is very hard game mode, I am too lazy, often use child and work as my excuse, ashamed...

Regards,
Leslie Zhai


Repository:
  rL LLVM

https://reviews.llvm.org/D32991

Files:
  ELF/InputFiles.cpp
  ELF/Target.cpp
  test/ELF/basic-avr.s
  test/lit.cfg

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D32991.101864.patch
Type: text/x-patch
Size: 3716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170608/48a29fdf/attachment.bin>