[PATCH] D31407: [PPC] In PPCBoolRetToInt change the bool value to i64 if the target is ppc64

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 15:19:02 PDT 2017


echristo added a comment.

One inline nit then LGTM.

-eric



================
Comment at: lib/Target/PowerPC/PPCBoolRetToInt.cpp:197
+    ST = nullptr;
+    if (TM)
+      ST = TM->getSubtargetImpl(F);
----------------
echristo wrote:
> Let's just always assume we have a TargetMachine and return false if not?
If you get a PPCTargetMachine you shouldn't have to cast the subtarget.


https://reviews.llvm.org/D31407





More information about the llvm-commits mailing list