[PATCH] D31921: Object: Factor out the code for creating the irsymtab for an arbitrary bitcode file.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added inline comments.


================
Comment at: llvm/include/llvm/Object/IRObjectFile.h:67
+
+namespace irsymtab {
+
----------------
tejohnson wrote:
> pcc wrote:
> > tejohnson wrote:
> > > why have this in the irsymtab namespace and not object? My main motivation for the move here is that irsymtab doesn't seem like the right namespace/layer for having the main entry point reading/building the full bitcode file contents. Or a new namespace (e.g. bitcodefile or bitcodeobject or the like).
> > To me these are still conceptually part of the irsymtab, I moved them here at your request. But I'm not going to pick this particular battle either, so ok, let's move them to `llvm::object`. Does `llvm::object::IRSymtabFile`/`llvm::object::readIRSymtab` sound fine?
> My belief is that the BitcodeModules are not part of the irsymtab (it seems we disagree on this point though). So I think llvm::object::File and llvm::object::readFile seem better.
Based on our offline discussion, your proposal seems like a reasonable interface.


https://reviews.llvm.org/D31921