[compiler-rt] r304943 - Revert "Fix tsan test for Darwin. NFCI."

Vedant Kumar via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 14:10:33 PDT 2017


Author: vedantk
Date: Wed Jun  7 16:10:33 2017
New Revision: 304943

URL: http://llvm.org/viewvc/llvm-project?rev=304943&view=rev
Log:
Revert "Fix tsan test for Darwin. NFCI."

This reverts commit r304941. Vitaly Buka writes:
"Actually it depends on return value.
Test is for char* version of function. It will probably fail for int
version."

Modified:
    compiler-rt/trunk/test/tsan/strerror_r.cc

Modified: compiler-rt/trunk/test/tsan/strerror_r.cc
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/tsan/strerror_r.cc?rev=304943&r1=304942&r2=304943&view=diff
==============================================================================
--- compiler-rt/trunk/test/tsan/strerror_r.cc (original)
+++ compiler-rt/trunk/test/tsan/strerror_r.cc Wed Jun  7 16:10:33 2017
@@ -10,8 +10,7 @@
 char buffer[1000];
 
 void *Thread(void *p) {
-  (void)strerror_r(TEST_ERROR, buffer, sizeof(buffer));
-  return p;
+  return strerror_r(TEST_ERROR, buffer, sizeof(buffer));
 }
 
 int main() {




More information about the llvm-commits mailing list