[PATCH] D33995: InferAddressSpaces: Avoid assertion failure with replacing identical cloned constexpr
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 7 13:30:52 PDT 2017
arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D33995#775320, @niravd wrote:
> In https://reviews.llvm.org/D33995#775210, @arsenm wrote:
>
> > I'm not sure I see why this would crash?
>
>
> I should have written it as assert. When the replacement is done, it assume that the new value is an address space cast and asserts in llvm::ConstantExpr::getAddrSpaceCast.
LGTM. Can you add a comment to this effect somewhere though
https://reviews.llvm.org/D33995
More information about the llvm-commits
mailing list