[PATCH] D33847: [PartialInlining] Enhance code outliner to sink locals declared outside the outline region

[Davide Italiano via Phabricator via llvm-commits]

davide added inline comments.


================
Comment at: include/llvm/Transforms/Utils/CodeExtractor.h:110
+
+    /// Check if life time marker nodes can be hoisted/sinked into the outline
+    /// region.
----------------
s/sinked/sunk/


================
Comment at: lib/Transforms/Utils/CodeExtractor.cpp:185-186
+          StoreInst *SI = cast<StoreInst>(&II);
+          if (!SI->isUnordered())
+            return false;
+          MemAddr = SI->getPointerOperand();
----------------
Can you add a comment explaining why you skip ordered load/stores?


https://reviews.llvm.org/D33847