[PATCH] D33784: Bug 33206 - Sanitizer CHECK failed: ((allocated_for_dlsym)) < ((kDlsymAllocPoolSize)) (1036, 1024)) with preload

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/asan/asan_malloc_linux.cc:83
 INTERCEPTOR(void*, realloc, void *ptr, uptr size) {
   GET_STACK_TRACE_MALLOC;
   if (UNLIKELY(IsInDlsymAllocPool(ptr))) {
----------------
Please add a realloc test, too.
I'm concerned that GET_STACK_TRACE_MALLOC reads flags that are only set up in AsanInitFromRtl.



================
Comment at: lib/asan/asan_malloc_linux.cc:98
   }
+  if (UNLIKELY(!asan_inited))
+    AsanInitFromRtl();
----------------
This is missing the case of realloc(0) while asan_init_is_running. I realize it does not happen in practice, but maybe handle it anyway for completeness.


https://reviews.llvm.org/D33784