[PATCH] D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

A couple of NFC changes that will reduce this patch.



================
Comment at: include/llvm/CodeGen/BasicTTIImpl.h:1121
+  /// The cost model should take into account that the actual length of the
+  /// vector is reduced on each iteration.
+  unsigned getArithmeticReductionCost(unsigned Opcode, Type *Ty,
----------------
You should probably move this comment (unchanged) as a NFC commit right away to reduce the patch. I can't tell if you've changed anything.


================
Comment at: include/llvm/Transforms/Vectorize/SLPVectorizer.h:87
 
-  /// \brief Try to vectorize a chain that may start at the operands of \V;
+  /// \brief Try to vectorize a chain that may start at the operands of \p V.
   bool tryToVectorize(BinaryOperator *V, slpvectorizer::BoUpSLP &R);
----------------
Do this as an NFC commit now - its a tidyup that isn't relevant to the patch.


https://reviews.llvm.org/D29402