[PATCH] D33847: [PartialInlining] Enhance code outliner to sink locals declared outside the outline region

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

One comment about simplifying the test. Other than that, LGTM.



================
Comment at: test/Transforms/CodeExtractor/live_shrink.ll:18-33
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
+  call void @_ZN1A7memfuncEv(%class.A* nonnull %tmp)
----------------
The target of the test is used to check whether alloca can be shrinked properly. Can we use -skip-partial-inlining-cost-analysis and simplify the test by keeping only one call @_ZN1A7memfuncEv?


https://reviews.llvm.org/D33847