[PATCH] D33901: [Go] GetSubtypes function

Andrew Wilkins via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jun 7 05:50:07 PDT 2017

Previous message: [PATCH] D33901: [Go] GetSubtypes function
Next message: [PATCH] D33901: [Go] Subtypes function
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

axw added a comment.

Sorry, I shouldn't really have said *suggest*. Can you please rename GetSubtypes to Subtypes? GetFoo is not idiomatic in Go (there are some instances of GetFoo in the existing code, but they're stuck like that until someone decides to break compatibility).


https://reviews.llvm.org/D33901

Previous message: [PATCH] D33901: [Go] GetSubtypes function
Next message: [PATCH] D33901: [Go] Subtypes function
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list