[PATCH] D33835: [LLD][ELF] Convert Thunks to use InputSectionDescriptions
Peter Smith via llvm-commits
llvm-commits at lists.llvm.org
Wed Jun 7 02:36:57 PDT 2017
Thanks very much for the review.
As of now nothing is so I've removed it. At the time I wrote the patch
it was still necessary to get the sections written. Thanks for
pointing that out.
Peter
On 6 June 2017 at 19:44, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
>
>> + // Add Thunks to OS->Sections
>> + for (InputSection *TS : Thunks)
>> + TS->getParent()->Sections.push_back(TS);
>
> What is using that instead of ISD? It is fine to keep it for now, just
> curious if you know what has to be converted.
>
> LGTM.
>
> Cheers,
> Rafael
More information about the llvm-commits
mailing list