[PATCH] D31349: IR: Replace the "Linker Options" module flag with "llvm.linker.options" named metadata.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D31349#710379, @rjmccall wrote:

> Clang side of this is fine.
>
> Conceptually, I guess this is an uncommonly-enough-used extension that we can just change it without breaking too many frontends.  I feel like you should probably check for the old module flag in the verifier, though; this is not something we should be silently ignoring.


Done.

(I'm refreshing this patch because I want to add another named metadata kind that is lowered to object files, and this patch contained the refactoring that allowed me to do that without being forced to go through module flags. I still think this is worth doing regardless of whether we do https://reviews.llvm.org/D31352 because this representation is simpler.)


https://reviews.llvm.org/D31349