[PATCH] D33874: Implement AllocateRWX and ReleaseRWX for NetBSD

[Joerg Sonnenberger via Phabricator via llvm-commits]

joerg added a comment.

Given that W^X is becoming a lot more popular across systems including SELinux and other variants, I think it would be better to extend MemoryBlock to store separate pointers for W and X mappings. That avoids the complexity of storing the pointer directly in the allocation.

Otherwise, please check for PROT_MPROTECT (and maybe additionally NetBSD) directly, not for the version. The version check is included in libffi only due to some complexity around mmap redefinitions which are not relevant here.


Repository:
  rL LLVM

https://reviews.llvm.org/D33874