[llvm] r304790 - Fix several more missing headers, all of these were hidden by "lucky"

Evgenii Stepanov via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 14:28:02 PDT 2017


Hi,

one of your changes in the range [304787, 304790] broke compilation on
the sanitizer-windows bot:

C:\b\slave\sanitizer-windows\build\bin\clang-cl.exe   /nologo
-DLLVM_BUILD_GLOBAL_ISEL -DUNICODE -D_CRT_NONSTDC_NO_DEPRECATE
-D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE
-D_CRT_SECURE_NO_WARNINGS -D_DEBUG_POINTER_IMPL=""
-D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_SCL_SECURE_NO_DEPRECATE
-D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib\Fuzzer
-IC:\b\slave\sanitizer-windows\llvm\lib\Fuzzer -Iinclude
-IC:\b\slave\sanitizer-windows\llvm\include /DWIN32 /D_WINDOWS /W3
/Zc:inline /Zc:strictStrings /Oi /Zc:rvalueCast /Brepro -Wall -W
-Wno-unused-parameter -Wwrite-strings -Wcast-qual
-Wmissing-field-initializers -Wcovered-switch-default
-Wdelete-non-virtual-dtor -Wstring-conversion /Oy- /Z7
-fsanitize=address
-fsanitize-coverage=trace-pc-guard,indirect-calls,trace-cmp
-fno-sanitize-coverage=trace-pc-guard,edge,trace-cmp,indirect-calls,8bit-counters
-Werror /MD /O2 /Ob2   -UNDEBUG /showIncludes
/Folib\Fuzzer\CMakeFiles\LLVMFuzzerNoMainObjects.dir\FuzzerExtFunctionsDlsymWin.cpp.obj
/Fdlib\Fuzzer\CMakeFiles\LLVMFuzzerNoMainObjects.dir\ -c
C:\b\slave\sanitizer-windows\llvm\lib\Fuzzer\FuzzerExtFunctionsDlsymWin.cpp
In file included from
C:\b\slave\sanitizer-windows\llvm\lib\Fuzzer\FuzzerExtFunctionsDlsymWin.cpp:16:
C:\Program Files (x86)\Windows
Kits\10\include\10.0.14393.0\um\Psapi.h(90,1):  error: unknown type
name 'BOOL'

http://lab.llvm.org:8011/builders/sanitizer-windows/builds/12494/steps/build%20LLVMFuzzer/logs/stdio

On Tue, Jun 6, 2017 at 5:31 AM, Chandler Carruth via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: chandlerc
> Date: Tue Jun  6 07:31:55 2017
> New Revision: 304790
>
> URL: http://llvm.org/viewvc/llvm-project?rev=304790&view=rev
> Log:
> Fix several more missing headers, all of these were hidden by "lucky"
> include ordering.
>
> Modified:
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h
>     llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h?rev=304790&r1=304789&r2=304790&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumDebugStreams.h Tue Jun  6 07:31:55 2017
> @@ -11,6 +11,7 @@
>  #define LLVM_DEBUGINFO_PDB_DIA_DIAENUMDEBUGSTREAMS_H
>
>  #include "DIASupport.h"
> +#include "llvm/DebugInfo/PDB/IPDBDataStream.h"
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
>
>  namespace llvm {
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h?rev=304790&r1=304789&r2=304790&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumLineNumbers.h Tue Jun  6 07:31:55 2017
> @@ -12,6 +12,7 @@
>
>  #include "DIASupport.h"
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
> +#include "llvm/DebugInfo/PDB/IPDBLineNumber.h"
>
>  namespace llvm {
>  namespace pdb {
>
> Modified: llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h?rev=304790&r1=304789&r2=304790&view=diff
> ==============================================================================
> --- llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h (original)
> +++ llvm/trunk/include/llvm/DebugInfo/PDB/DIA/DIAEnumSourceFiles.h Tue Jun  6 07:31:55 2017
> @@ -12,6 +12,7 @@
>
>  #include "DIASupport.h"
>  #include "llvm/DebugInfo/PDB/IPDBEnumChildren.h"
> +#include "llvm/DebugInfo/PDB/IPDBSourceFile.h"
>
>  namespace llvm {
>  namespace pdb {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list