[PATCH] D33919: [ADT] Ensure that correct overrides for SmallVector assign are selected

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 12:54:41 PDT 2017


I feel like this should probably be implemented the same way as the
standard requires - if the type is not a forward iterator, rather than
non-integral. (you could imagine/create a test case for a situation where
there's a type that's implicitly convertible to an integral type (for use
as the offset point in an append call) & either the value type or
convertible to it - but not an integral type)

& also this should be tested and similar solution probably applied to the
"assign(iter, iter)" and the (iter, iter) ctor.

On Tue, Jun 6, 2017 at 11:37 AM Francis Ricci via Phabricator <
reviews at reviews.llvm.org> wrote:

> fjricci added a subscriber: efriedma.
> fjricci added a comment.
>
> Accidentally removed a subscriber, re-adding
>
>
> https://reviews.llvm.org/D33919
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170606/002332fc/attachment.html>


More information about the llvm-commits mailing list