[PATCH] D33688: [Polly] Heap allocation for new arrays
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 6 11:44:18 PDT 2017
Meinersbur added a comment.
I am wondering why you decided for a global stack-or-heap property. I'd assumed that this is a per-array decision. For instance, Roman's gemm optimization is designed to fit on the stack, there is no reason to allocate it on the heap.
================
Comment at: lib/CodeGen/IslNodeBuilder.cpp:1430-1434
+ auto *CreatedArray = CallInst::CreateMalloc(
+ &*InstIt, IntPtrTy, SAI->getElementType(),
+ ConstantInt::get(Type::getInt64Ty(Ctx), Size),
+ ConstantInt::get(Type::getInt64Ty(Ctx), ArraySizeInt), nullptr,
+ SAI->getName());
----------------
Where is the memory free'd?
https://reviews.llvm.org/D33688
More information about the llvm-commits
mailing list