[PATCH] D33647: [ELF] - Linkerscript: implement NOLOAD section type.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Tue Jun 6 11:22:12 PDT 2017
LGTM with startswith converted to 'peek() != "("', but wait for Rui's
approval too.
Cheers,
Rafael
Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:
> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/ScriptParser.cpp:574
> + // https://sourceware.org/binutils/docs/ld/Output-Section-Address.html
> + if (!peek().startswith("("))
> + Cmd->AddrExpr = readExpr();
> ----------------
> Why can't you do `peek() != "("`?
>
>
> https://reviews.llvm.org/D33647
More information about the llvm-commits
mailing list