[PATCH] D33886: Reduce the size of output with -print-before/after-all by avoid duplicated dump

[Hiroshi Inoue via Phabricator via llvm-commits]

inouehrs marked an inline comment as done.
inouehrs added a comment.

@mehdi_amini I want to be less intrusive especially in Module. I like to pack most of the changes in PMDataManager to be less intrusive in Module, but I cannot find a good way to access PMDataManager (i.e. PassManager) from AsmWriter. I appreciate any further suggestions.

@npjdesres Your suggested output looks quite nice. But I do not implement it so far because I need to be add further code to record the last pass without modification. I am investigating a good way to improve the message.



================
Comment at: lib/IR/Module.cpp:96
+  if (FuncsUnchangedAfterDump != nullptr)
+    delete FuncsUnchangedAfterDump;
 }
----------------
mehdi_amini wrote:
> Why aren't you using a smart pointer?
I rewrote the change in Module with a smart pointer.


https://reviews.llvm.org/D33886