[PATCH] D33688: [Polly] Heap allocation for new arrays

[Andreas Simbuerger via Phabricator via llvm-commits]

simbuerg added a comment.

So far it looks good. I would add tests that take care of error cases: negative sizes, overflow in the size calculation.



================
Comment at: lib/CodeGen/IslNodeBuilder.cpp:1420
+
+    if (PollyAllocateArraysHeap) {
+      LLVMContext &Ctx = NewArrayType->getContext();
----------------
You already wrote it in your diff-summary: I would make this a property of the SAI and fill this information from the JSON side.


https://reviews.llvm.org/D33688