[PATCH] D33892: Align definition of DW_OP_plus with DWARF spec [1/3]

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In https://reviews.llvm.org/D33892#772876, @aprantl wrote:

> Thanks, this is great! The only thing that is missing here is a bitcode upgrade that transforms the old use of DW_OP_plus to DW_OP_plus_uconst. I recommend incrementing the "Version number" in operand 0 of DIExpression to distinguish between the old and new format. You can look at r300522 for an example of how to do this.


Thanks for pointing this out! I hope my changes to the patch reflect what you suggested.

Initially the diff also contained a binary diff for the changed .bc files, but these are not needed now as the old .bc files check backward compatibility as implemented in the 'upgradeMetadataExpression()' function. If I want to add binary changes to my patch though, how could I add these? (Phabricator failed to accept my initial diff that I created using git diff --binary)


https://reviews.llvm.org/D33892