[PATCH] D33934: [BPI] Don't assume that strcmp returning >0 is more likely than <0

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added reviewers: iteratee, davidxl.
chandlerc added a comment.

Generally makes sense, but maybe check the intuition of some other folks who've been hacking on static heuristics recently... Also, a small simplifying (I hope) comment inline.



================
Comment at: include/llvm/Analysis/BranchProbabilityInfo.h:48
+  BranchProbabilityInfo(const Function &F, const LoopInfo &LI,
+                        const TargetLibraryInfo *TLI = nullptr) {
+    calculate(F, LI, TLI);
----------------
Is all of the support for null TLI necessary? It seems like we should always be able to provide it..


Repository:
  rL LLVM

https://reviews.llvm.org/D33934