[PATCH] D33843: Create a new library called ObjectLayout, and move headers from Support to there.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jun 6 04:56:42 PDT 2017


chandlerc added a comment.

In https://reviews.llvm.org/D33843#773577, @chandlerc wrote:

> In https://reviews.llvm.org/D33843#773575, @zturner wrote:
>
> > If there are specific files you're seeing in that I didn't find, LMK.
>
>
> There are. Let me try updating them quickly and a rebase should fix it right up.


Yeah, the include order was just chaos everywhere in LLVM. I hadn't run scripts in too long. I wrote new scripts that directly use clang-format and updated all the include orderings so this kind of patch should be trivial. You should be able to just resolve all the conflicts in one direction or the other regardless and then run clang-format again.

You may want to patch https://reviews.llvm.org/D33932 into clang-format to handle the unittests, but hopefully we'll get that landed ASAP.


https://reviews.llvm.org/D33843





More information about the llvm-commits mailing list