[PATCH] D33552: [ELF] - Make implementation of .gdb index to be more natural for futher paralleling.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1787
+
+      CuVectors[Sym->CuVectorIndex].insert((uint32_t)CuId |
+                                           (NameType.Type << 24));
----------------
ruiu wrote:
> If `CuId` is actually a 32-bit type, define it as `uint32_t` from the beginning.
Done.


================
Comment at: ELF/SyntheticSections.cpp:1810
+  Ret.NamesAndTypes = readPubNamesAndTypes(Dwarf, Config->IsLE);
 
+  return Ret;
----------------
ruiu wrote:
> Remove a blank line.
Done.


================
Comment at: ELF/SyntheticSections.cpp:1871-1872
+    for (CompilationUnitEntry &CU : D.CompilationUnits) {
+      write64le(Buf, CU.CuOffset);
+      write64le(Buf + 8, CU.CuLength);
+      Buf += 16;
----------------
ruiu wrote:
> Be consistent -- don't mix CU and Cu. Use `Cu` consistently in this patch.
Done.


https://reviews.llvm.org/D33552