[PATCH] D33647: [ELF] - Linkerscript: implement NOLOAD section type.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/LinkerScript.h:138
   std::string MemoryRegionName;
+  bool ForceToNoBits = false;
 
----------------
ruiu wrote:
> `Noload` is probably a better name.
Done.


================
Comment at: ELF/ScriptParser.cpp:575
 
+  // Read section type. Only NOLOAD is supported currently.
+  // https://sourceware.org/binutils/docs/ld/Output-Section-Type.html
----------------
ruiu wrote:
> Read a section type. Currently, only NOLOAD is supported.
Done.


================
Comment at: ELF/ScriptParser.cpp:577
+  // https://sourceware.org/binutils/docs/ld/Output-Section-Type.html
+  if (peek() != ":") {
+    expect("(");
----------------
ruiu wrote:
> You can move this above `if (peek() != ":")`, no?
Do you mean something like this (new diff) ?


https://reviews.llvm.org/D33647