[PATCH] D33867: [DWARF] Introduce -brief command line option to llvm-dwarfdump

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 20:48:50 PDT 2017


aprantl added a comment.

It looks like you accidentally created a diff between your last patch and the new version. When uploading a revised patch, please always upload the diff from svn trunk.



================
Comment at: test/tools/llvm-dwarfdump/X86/brief.s:7
 # CHECK-NOT: [{{[0-9]+}}]
 # CHECK-NOT: DW_FORM
 
----------------
What David meant here was that
`CHECK-NOT: DW_FORM`
is also true for empty output.
If we instead check for
```CHECK: DW_TAG_compile_unit
CHECK-NOT: DW_FORM
CHECK: DW_AT```

or (probably better)

`CHECK: DW_TAG_compile_unit {{$}}`

We match an entire line of output and the test case is more robust.


https://reviews.llvm.org/D33867





More information about the llvm-commits mailing list