[PATCH] D29892: ar: add llvm-dlltool support

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 16:37:05 PDT 2017


> Index: lib/Object/COFFObjectFile.cpp
> ===================================================================
> --- lib/Object/COFFObjectFile.cpp
> +++ lib/Object/COFFObjectFile.cpp
> @@ -227,8 +227,9 @@
>    if (Symb.isExternal() || Symb.isWeakExternal())
>      Result |= SymbolRef::SF_Global;
>  
> +  // SF_Indirect so the archiver can write weak externs
>    if (Symb.isWeakExternal())
> -    Result |= SymbolRef::SF_Weak;
> +    Result |= SymbolRef::SF_Weak + SymbolRef::SF_Indirect;

You probably want |, not +.


Cheers,
Rafael


More information about the llvm-commits mailing list