[PATCH] D32881: Read public symbol names for LazyObjectFiles in parallel.

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 16:07:16 PDT 2017


Rui Ueyama <ruiu at google.com> writes:

> On Wed, May 31, 2017 at 6:36 PM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> Rui Ueyama <ruiu at google.com> writes:
>>
>> > Here is the table of your benchmark results. It seems they aren't
>> different
>> > to me.
>>
>> There is very little difference in using an index or not. The regression
>> is from without the patch to with the patch:
>
>
> If there's an index, the patch has totally no effect. And we got the almost
> same numbers for the test cases without an index.That sounds like we are
> handling archives without indices. What am I missing?

There is still the stringsaver change. I am not sure why, but the patch
causes a regression when threads are used. That is true both with or
without an index.

Cheers,
Rafael


More information about the llvm-commits mailing list