[PATCH] D33685: [InlineCost] Change CallAnalyzer::isGEPFree to use TTI::getUserCost instead of TTI::getGEPCost

Evgeny Astigeevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 13:49:06 PDT 2017


eastig added a comment.

In https://reviews.llvm.org/D33685#768949, @efriedma wrote:

> We could add a version of getUserCost() which takes both an instruction and a list of operands, I guess?


Yes, I've got the similar idea. After some thinking about it, I am not sure it should be a list. I see in the original code the name 'SimplifiedValues' is used with an lookup interface. I think something similar should be used.
How about llvm/IR/ValueMap.h? Or maybe DenseMap?


https://reviews.llvm.org/D33685





More information about the llvm-commits mailing list