[PATCH] D33795: [PredicateInfo] Remove -reverse-iterate from tests as it breaks on Release builds

Grang, Mandeep Singh via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 12:43:03 PDT 2017


On 6/5/2017 11:38 AM, David Blaikie wrote:
> Is it possible/would it make sense to have a buildbot that runs 
> everything with reverse-iterate? (not sure if that can be easily 
> plumbed through to all invocations of llvm tools, etc)

We do this internally by enabling reverse-iteration by default through 
build macro.

I have pushed this patch: https://reviews.llvm.org/D33908

Please take a look.

--Mandeep

>
> Much like asan, etc, rather than building specific test cases that run 
> parts of LLVM under asan - there's a bot that runs it all.
>
> On Thu, Jun 1, 2017 at 12:08 PM Mandeep Singh Grang via Phabricator 
> via llvm-commits <llvm-commits at lists.llvm.org 
> <mailto:llvm-commits at lists.llvm.org>> wrote:
>
>     mgrang created this revision.
>
>     Repository:
>       rL LLVM
>
>     https://reviews.llvm.org/D33795
>
>     Files:
>       test/Transforms/Util/PredicateInfo/condprop.ll
>       test/Transforms/Util/PredicateInfo/testandor.ll
>
>
>     Index: test/Transforms/Util/PredicateInfo/testandor.ll
>     ===================================================================
>     --- test/Transforms/Util/PredicateInfo/testandor.ll
>     +++ test/Transforms/Util/PredicateInfo/testandor.ll
>     @@ -1,6 +1,5 @@
>      ; NOTE: Assertions have been autogenerated by
>     utils/update_test_checks.py
>      ; RUN: opt -print-predicateinfo < %s 2>&1 | FileCheck %s
>     -; RUN: opt -print-predicateinfo -reverse-iterate < %s 2>&1 |
>     FileCheck %s
>
>      declare void @foo(i1)
>      declare void @bar(i32)
>     Index: test/Transforms/Util/PredicateInfo/condprop.ll
>     ===================================================================
>     --- test/Transforms/Util/PredicateInfo/condprop.ll
>     +++ test/Transforms/Util/PredicateInfo/condprop.ll
>     @@ -1,6 +1,5 @@
>      ; NOTE: Assertions have been autogenerated by
>     utils/update_test_checks.py
>      ; RUN: opt -print-predicateinfo -analyze  < %s 2>&1 | FileCheck %s
>     -; RUN: opt -print-predicateinfo -analyze -reverse-iterate < %s
>     2>&1 | FileCheck %s
>
>      @a = external global i32               ; <i32*> [#uses=7]
>
>
>
>     _______________________________________________
>     llvm-commits mailing list
>     llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
>     http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170605/e714aaa9/attachment.html>


More information about the llvm-commits mailing list