[PATCH] D33665: [GlobalISel][X86] support G_MERGE_VALUES/G_UNMERGE_VALUES selection.

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet requested changes to this revision.
qcolombet added a comment.
This revision now requires changes to proceed.

Hi Igor,

It seems to me that the patch could be split into finer grain patches.

- API change (getRegClassForTypeOnBank to getRegClass)
- One change for each different select (unmerge, merge, copy, etc.)
- Legality setting

Please use the .mir framework to test separately each new thing (like one test for the legality change, one for the select part). Of course bitcode to asm are still useful as integration tests and should be kept.

Cheers,
-Quentin


https://reviews.llvm.org/D33665