[PATCH] D33809: CodeGen: Refactor MIR parsing

[Quentin Colombet via Phabricator via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM.
Nitpicks below



================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:153
+  /// Creates a new MachineFunction if none exists yet.
   MachineFunction &getMachineFunction(const Function &F);
 
----------------
Rename to getOrCreateMachineFunction


================
Comment at: include/llvm/CodeGen/MachineModuleInfo.h:157
+  /// is one, otherwise nullptr.
+  MachineFunction *queryMachineFunction(const Function &F) const;
+
----------------
Rename to getMachineFunction


================
Comment at: lib/CodeGen/MIRParser/MIRParser.cpp:64
+  bool NoLLVMIR = false;
+  bool NoMIRDocuments = false;
 
----------------
Could you add a comment for that variable too?


Repository:
  rL LLVM

https://reviews.llvm.org/D33809