[PATCH] D33848: Do not recombine FMA when that is not needed.

[Amaury SECHET via Phabricator via llvm-commits]

deadalnix added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:34158
 
+  if (N->getOpcode() == X86ISD::FMADD || N->getOpcode() == ISD::FMA) {
+    if (HasNeg || NewOpcode != N->getOpcode())
----------------
zvi wrote:
> In addition to this change, would it be better to refactor the if-else  chain into a switch statement?
You tell me :) I'm not such a siwhc with another switch in each 'case' would be clearer TBH.


https://reviews.llvm.org/D33848