[PATCH] D32835: [compiler-rt] [cmake] Support generic installation

[Jonathan Roelofs via Phabricator via llvm-commits]

jroelofs added inline comments.


================
Comment at: CMakeLists.txt:37
 
+set(COMPILER_RT_LIBRARY_INSTALL_DIR "" CACHE PATH
+  "compiler-rt library install path")
----------------
ditto for `COMPILER_RT_LIBRARY_OUTPUT_DIR`


================
Comment at: cmake/Modules/AddCompilerRT.cmake:138
+  elseif(COMPILER_RT_LIBNAME)
+    set(libname "${name}")
+    set(output_name_${libname} ${libname}${COMPILER_RT_OS_SUFFIX})
----------------
this should be:

```
set(libname ${COMPILER_RT_LIBNAME})
```


================
Comment at: cmake/Modules/AddCompilerRT.cmake:142
+    set(libnames ${libnames} ${libname})
+    set(extra_cflags_${libname} ${LIB_CFLAGS})
   else()
----------------
we need a call to `format_object_libs` here, I think.


================
Comment at: cmake/base-config-ix.cmake:70
 set(COMPILER_RT_LIBRARY_OUTPUT_DIR
   ${COMPILER_RT_OUTPUT_DIR}/lib/${COMPILER_RT_OS_DIR})
+if (NOT COMPILER_RT_LIBRARY_INSTALL_DIR)
----------------
we need the same for `COMPILER_RT_LIBRARY_OUTPUT_DIR` too


https://reviews.llvm.org/D32835