[PATCH] D33003: Add callee-saved registers as implicit uses in return instructions

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 09:14:23 PDT 2017


kparzysz added inline comments.


================
Comment at: lib/CodeGen/PrologEpilogInserter.cpp:985-986
+  SmallVector<unsigned,4> Regs, PristRegs;
+  for (int x = Pristine.find_first(); x >= 0; x = Pristine.find_next(x))
+    PristRegs.push_back(x);
+
----------------
MatzeB wrote:
> Francis landed a patch recently that finally allows `for(unsigned PRegs : Pristine.set_bits())`. Similar in a few other places here (though as noted in the general comments, it feels like too many unnecessary intermediate bitsets to me).
Removed this particular statement, but used the set_bits range in other places.


Repository:
  rL LLVM

https://reviews.llvm.org/D33003





More information about the llvm-commits mailing list