[PATCH] D33892: Align definition of DW_OP_plus with DWARF spec [1/3]

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 5 08:48:33 PDT 2017


aprantl requested changes to this revision.
aprantl added a comment.
This revision now requires changes to proceed.

Thanks, this is great! The only thing that is missing here is a bitcode upgrade that transforms the old use of DW_OP_plus to DW_OP_plus_uconst. I recommend incrementing the "Version number" in operand 0 of DIExpression to distinguish between the old and new format. You can look at r300522 for an example of how to do this.


https://reviews.llvm.org/D33892





More information about the llvm-commits mailing list