[PATCH] D33513: [ThinLTO] Fix ThinLTO crash while destroying context

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

In https://reviews.llvm.org/D33513#772857, @mehdi_amini wrote:

> In https://reviews.llvm.org/D33513#772844, @ncharlie wrote:
>
> > Addressed comments. Formatted with clang-format, so that's why there are so many extra changes in the diff.
>
>
> The common practice is that we never clang-format the full files. That's why LLVM has clang/tools/clang-format/git-clang-format ; if your commit is the last one in the history you can run `git clang-format HEAD~`  and it'll format only the statements touched by this last commit (you can also format changes that are about to be committed with `git clang-format -f`).


So, clang-formatt'ing the whole file is generally a good thing.
What I recommend is splitting that change in a separate NFC commit, and then reapply your patch on top of it.


https://reviews.llvm.org/D33513